Closed saschagrunert closed 4 weeks ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: saschagrunert, SergeyKanzhelev
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind bug
What this PR does / why we need it:
Only the first entry would be written before applying this patch. This means that a config like this:
Would return the right value (the last one):
But setting the config will only result in setting the first item:
And therefore also a wrong result of
crictl config --get
:We now change that behavior and set all values without de-duplicating them:
e2e test cases around that scenario have been added as well.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Follow-up on https://github.com/kubernetes-sigs/cri-tools/pull/1659#discussion_r1817010069
Does this PR introduce a user-facing change?