kubernetes-sigs / cri-tools

CLI and validation tools for Kubelet Container Runtime Interface (CRI) .
Apache License 2.0
1.69k stars 454 forks source link

Clarify that `crictl config` without args refers to `set` #1662

Closed saschagrunert closed 4 weeks ago

saschagrunert commented 4 weeks ago

What type of PR is this?

/kind documentation

What this PR does / why we need it:

It's not clear to the end user that not specifying --list, --set or --get will result in a configuration set. We now clarify that in the docs as well as logs of the option.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Update `crictl config` documentation to clarify that `crictl config` without args refers to `--set`.
k8s-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cri-tools/blob/master/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment