Closed olivierlemasle closed 1 year ago
@olivierlemasle: This issue is currently awaiting triage.
If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
I've updated the PR to follow your suggestions.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgrisonnet, olivierlemasle
The full list of commands accepted by this bot can be found here.
The pull request process is described here
... but the ones in the test-adapter provider need to be reflected in https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/docs/getting-started.md. That can be done in a follow-up but we need to make sure that we keep the doc up-to-date.
Yes, I'm thinking about it since #108. I've just opened an issue for that topic: #132.
@olivierlemasle @dgrisonnet would be nice to have all exposed metrics documented somewhere.
I opened an issue to keep track of that: https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/134
Add a metric
custom_metrics_apiserver_metric_freshness_seconds
, similar to the metricmetrics_server_api_metric_freshness_seconds
from metrics-server.This metric can optionally be registered using
RegisterMetrics(registrationFunc func(metrics.Registerable) error) error
, e.g:Also, in test-adapter:
custom_metrics_apiserver_metric_freshness_seconds
;