resClient.List should add resourceVersion=0 parameter

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes

Apache License 2.0

499 stars 175 forks source link

resClient.List should add resourceVersion=0 parameter #154

Closed xiaomudk closed 1 week ago

xiaomudk commented 1 year ago

resourceVersion=0 is not specified here, causing apiserver to skip the cache and go directly to etcd to read the data. add resourceVersion=0 parameter, apiserver will read data from the cache, and there is an order of magnitude performance improvement.

logicalhan commented 1 year ago

/triage accepted /assign

dgrisonnet commented 1 year ago

I don't think that's something we want to do since it might be hitting stale data from the cache.

k8s-triage-robot commented 2 weeks ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

dashpole commented 1 week ago

/close based on https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/154#issuecomment-1705572167

k8s-ci-robot commented 1 week ago

@dashpole: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/154#issuecomment-2332222269): >/close >based on https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/154#issuecomment-1705572167 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.