custom-metrics-apiserver compile failed with k8s.io/apiserver v0.29.2

selamat commented 6 months ago

HI, my go application using

sigs.k8s.io/custom-metrics-apiserver v1.28.0
k8s.io/apiserver v0.29.2

and it can't compile succeed because of this function func (o CustomMetricsAdapterServerOptions) ApplyTo(serverConfig genericapiserver.Config) error . In this function, it called ApplyTo in package k8s.io/apiserver, but in v0.29.2version, ApplyTo has 3 parameters. Also I compare k8s.io/apiserver between v0.29 and v0.28, in version0.28, ApplyTo has only 1 parameter.

Maybe I think custom-metrics-apiserver should fit kubernetes v1.29

k8s-ci-robot commented 6 months ago

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

RainbowMango commented 5 months ago

cc @dgrisonnet

/help

k8s-ci-robot commented 5 months ago

@RainbowMango: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/167): >cc @dgrisonnet > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dgrisonnet commented 5 months ago

Hi @selamat, yeah it sounds like we will need to bump the k8s dependencies to the latest ones so v1.29.3. I'll take care of it and publish a release soon.

/assign

RainbowMango commented 5 months ago

Yes, it is the v1.29.3. Thank you @dgrisonnet in advance.

kubernetes-sigs / custom-metrics-apiserver

custom-metrics-apiserver compile failed with k8s.io/apiserver v0.29.2 #167

Guidelines