kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

Fix minor typo in pkg/provider/interfaces.go #41

Closed fj closed 5 years ago

k8s-ci-robot commented 5 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fj commented 5 years ago

Hello! I've signed the CLA now.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fj commented 5 years ago

/remove-lifecycle stale

also /cc'ing @DirectXMan12 as per the robot suggestion

DirectXMan12 commented 5 years ago

FYI: I'm no longer working on metrics stuff as much -- ping @s-urbaniak :-)

s-urbaniak commented 5 years ago

/lgtm

k8s-ci-robot commented 5 years ago

@s-urbaniak: changing LGTM is restricted to assignees, and only kubernetes-incubator/custom-metrics-apiserver repo collaborators may be assigned issues.

In response to [this](https://github.com/kubernetes-incubator/custom-metrics-apiserver/pull/41#issuecomment-489552734): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
s-urbaniak commented 5 years ago

/assign

k8s-ci-robot commented 5 years ago

@s-urbaniak: GitHub didn't allow me to assign the following users: s-urbaniak.

Note that only kubernetes-incubator members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-incubator/custom-metrics-apiserver/pull/41#issuecomment-489552823): >/assign Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kawych commented 5 years ago

/lgtm /approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-incubator/custom-metrics-apiserver/blob/master/OWNERS)~~ [kawych] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kylee12 commented 5 years ago

Never signed up for this my husband probably did Raymond Zimmerman but he passed away may 24 2017