search

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

Update to K8s 1.15.x libraries #56

Closed mattmoor closed 4 years ago

mattmoor commented 5 years ago

There were a number of changes in 1.15.x that break callsites in this library, so consumers of this library are unable to update to 1.15.x until this library has been updated.

We currently use this as the basis for integrating our request metrics with HPA-based autoscaling in Knative, and I'd like to see us move to 1.15.x libs in our next milestone (starts tomorrow).

Any chance we can get this moved forward?

cc @markusthoemmes @vagababov @josephburnett

CharlyF commented 5 years ago

👋 @mattmoor - I faced the same problem. Opened this earlier today https://github.com/kubernetes-incubator/custom-metrics-apiserver/pull/55 Hopefully this (or any similar contribution) can be merged soon.

mattmoor commented 5 years ago

😍

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

markusthoemmes commented 4 years ago

This is done.

/close

k8s-ci-robot commented 4 years ago

@markusthoemmes: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/custom-metrics-apiserver/issues/56#issuecomment-565970938): >This is done. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.