search

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

update dependencies management instruction in CONTRIBUTING.md #60

Closed ydcool closed 4 years ago

ydcool commented 4 years ago

Signed-off-by: Dominic Yin yindongchao@inspur.com

Updated dependencies instruction in CONTRIBUTING.md:

  1. The dependency management tool has changed from go dep to go module.
  2. Kubernetes documents has moved to new repository, so the link should be updated. See https://github.com/kubernetes/kubernetes/pull/39120
k8s-ci-robot commented 4 years ago

Welcome @ydcool!

It looks like this is your first PR to kubernetes-incubator/custom-metrics-apiserver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/custom-metrics-apiserver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ydcool commented 4 years ago

/assign @luxas

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

s-urbaniak commented 4 years ago

/remove-lifecycle stale

s-urbaniak commented 4 years ago

/lgtm

s-urbaniak commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, ydcool

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/OWNERS)~~ [s-urbaniak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment