search

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

Remove glide #61

Closed guineveresaenger closed 4 years ago

guineveresaenger commented 4 years ago

Glide is old. We should not use it anymore.

This PR removes the vendor folder, the glide.lock and glide.yaml and adds a warning to the getting-started tutorial that the same is in need of updating.

/assign @kawych /cc @brendanjryan

k8s-ci-robot commented 4 years ago

@guineveresaenger: GitHub didn't allow me to request PR reviews from the following users: brendanjryan.

Note that only kubernetes-incubator members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-incubator/custom-metrics-apiserver/pull/61): >Glide is old. We should not use it anymore. > >This PR removes the `vendor` folder, the `glide.lock` and `glide.yaml` and adds a warning to the `getting-started` tutorial that the same is in need of updating. > >/assign @kawych >/cc @brendanjryan > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

Welcome @guineveresaenger!

It looks like this is your first PR to kubernetes-incubator/custom-metrics-apiserver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/custom-metrics-apiserver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

guineveresaenger commented 4 years ago

@s-urbaniak I hear you may be an active reviewer on this project?

s-urbaniak commented 4 years ago

/lgtm yes, and thank you for submitting this PR! This lgtm :tada: As we already have the infrastructure in place for Go modules, I am fine with proceeding here. I just did a check and it seems the most prominent consumers of this library seem to have switched to Go modules already too:

The only exception I see is (still at Godeps):

s-urbaniak commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guineveresaenger, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/OWNERS)~~ [s-urbaniak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment