search

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

Fix openapi rendering issue and build tooling improvements #75

Closed johanneswuerbach closed 3 years ago

johanneswuerbach commented 3 years ago

Resolves "Failed to build open api spec for root: non-body Restful parameter type should be a simple type, but got : v1.ResourceVersionMatch"

johanneswuerbach commented 3 years ago

/assign @s-urbaniak

s-urbaniak commented 3 years ago

@johanneswuerbach wonderful, thank you! reviewing and also cc'ing @dgrisonnet

s-urbaniak commented 3 years ago

/lgtm

s-urbaniak commented 3 years ago

lgtm, again, thank you so much @johanneswuerbach ! :rocket:

s-urbaniak commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johanneswuerbach, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/OWNERS)~~ [s-urbaniak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
s-urbaniak commented 3 years ago

@johanneswuerbach do you want to tackle the bump in prometheus-adapter as well? Once done, I can release a 0.8.2 immediately.

johanneswuerbach commented 3 years ago

Yes, working on it now :-)

s-urbaniak commented 3 years ago

@johanneswuerbach fyi: @dgrisonnet found out something is broken with the build though.

johanneswuerbach commented 3 years ago

Let me know if you need any help, here is the k8s-prometheus-adapter PR https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/335

dgrisonnet commented 3 years ago

The fix seems to be working properly as far as I tested with the test-adapter so I think we can move on with the prometheus-adapter bump. However, when I was trying to build this project in a freshly cloned repo, the openapi files were not getting generated, which resulted in build errors.