search

kubernetes-sigs / custom-metrics-apiserver

Framework for implementing custom metrics support for Kubernetes
Apache License 2.0
504 stars 176 forks source link

bump deps & k8s deps to v0.23.3 #97

Closed zroubalik closed 2 years ago

zroubalik commented 2 years ago

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Can we have a new release with these deps?

k8s-ci-robot commented 2 years ago

Hi @zroubalik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dgrisonnet commented 2 years ago

/ok-to-test

dgrisonnet commented 2 years ago

Seems like there is an issue during build: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_custom-metrics-apiserver/97/pull-custom-metrics-apiserver-build-test-adapter/1486279390277931008

As far as I can tell it seems related to https://github.com/kubernetes-sigs/controller-tools/issues/643 which looks solvable by updating go to 1.17, could you look into that?

dgrisonnet commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, tomkerkhove, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment