kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.47k stars 668 forks source link

Default evictor nodeFit has incorrect default value in v1alpha2 #1142

Closed a7i closed 1 year ago

a7i commented 1 year ago

What version of descheduler are you using?

descheduler version: v0.27.0

Does this issue reproduce with the latest release? Yes

Which descheduler CLI options are you using?

Please provide a copy of your descheduler policy config file

    apiVersion: "descheduler/v1alpha2"
    kind: "DeschedulerPolicy"
    maxNoOfPodsToEvictPerNamespace: 20
    maxNoOfPodsToEvictPerNode: 10
    profiles:
    - name: nofit
      pluginConfig:
      - args:
          # note that nodeFit is not set here!!
          evictLocalStoragePods: true
          evictSystemCriticalPods: true
          nodeSelector: node-type notin (api,control-plane,etcd,etcd-events)
        name: DefaultEvictor
      - args:
          maxPodLifeTimeSeconds: 172800
        name: PodLifeTime
      plugins:
        deschedule:
          enabled:
          - PodLifeTime

What k8s version are you using (kubectl version)? 1.24

kubectl version Output
$ kubectl version

What did you do?

Per the docs, the default value of nodeFit is false. Run Descheduler with the policy attached.

What did you expect to see? nodeFit to be false

What did you see instead? nodeFit is set to true