search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.47k stars 668 forks source link

fix: imagepullsecrets indentation for kind: Deployment #1150

Closed a7i closed 1 year ago

a7i commented 1 year ago

before fix:

❯ helm template descheduler . --set 'imagePullSecrets[0].name=test' --set 'kind=Deployment' | grep imagePullSecrets -B 1 -A 2
      serviceAccountName: descheduler
      imagePullSecrets:
          - name: test
      containers:

after fix:

❯ helm template descheduler . --set 'imagePullSecrets[0].name=test' --set 'kind=Deployment' | grep imagePullSecrets -B 1 -A 2
      serviceAccountName: descheduler
      imagePullSecrets:
      - name: test
      containers:
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [damemi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
a7i commented 1 year ago

/cc @JaneLiuL