Closed ingvagabund closed 1 year ago
/approve
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a7i, damemi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/retest-required
/retest-required
/retest-required
/retest-required
golangci/golangci-lint info checking GitHub for tag 'v1.52.1'
golangci/golangci-lint info found version: 1.52.1 for v1.52.1/linux/amd64
golangci/golangci-lint info installed ./_output/bin/golangci-lint
./_output/bin/golangci-lint run
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
$ /usr/bin/golangci-lint --version
golangci-lint has version 1.52.1 built with go1.20.2 from d92b38cc on 2023-03-21T19:48:38Z
$ /usr/bin/golangci-lint run
No timeout locally.
$ time /usr/bin/golangci-lint run
real 0m0.883s
user 0m3.328s
sys 0m0.524s
$ /usr/bin/golangci-lint run --help
Run the linters
...
--timeout duration Timeout for total work (default 1m0s)
A minute should be enough. Unless the CI container runs for longer.
It takes 15m15s to run the entire pull-descheduler-verify-master /O\
/retest-required
Huge clusters with thousands of pods can quickly exceed the default watch channel size of the fake clientset. Causing the channel to panic with "channel full".