search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.36k stars 662 forks source link

[FR] Per-strategy dry-run mode #1176

Closed evgkrsk closed 5 months ago

evgkrsk commented 1 year ago

Is your feature request related to a problem? Please describe. We use descheduler (thanks for it!) in our production clusters, but here is problem: to see effect of enabling new descheduling strategy without risk, you have to enable dry-run mode. But it is global (per-instance) switch, so you can't continue to apply already tested and fine-tuned strategy(es) and test new strategy safely.

Describe the solution you'd like Per-strategy option in policy definition to enable dry-run for current strategy only (disabled by default for backward compatibility).

Describe alternatives you've considered Many descheduler instances with different dry-run modes (on/off). Also, instances in dry-run mode have to disable leader election, in opposite to instances not in dry-run mode. Seems like resources and efforts waste for me.

What version of descheduler are you using?

descheduler version: latest at 16 Jun 2023.

Additional context It would be useful to add dry-run bool label in prometheus metrics to help with testing new strategies.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/descheduler/issues/1176#issuecomment-2015678255): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.