search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.45k stars 666 forks source link

feat: Enable open telemetry tracing #1189

Closed harshanarayana closed 1 year ago

harshanarayana commented 1 year ago

Reworking the changes from #958 as is got too mess to cleanup and rework the changes easily since a lot of things changed during the framework rebuild.

Thanks and Credits to @Dentrax for the help and contribution in the original PR under #958

Screenshot 2023-07-17 at 12 46 40 AM
k8s-ci-robot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

harshanarayana commented 1 year ago

@a7i @damemi I have ported the changes from #958 into this and addressed most of the comments that were left on that thread in terms of reusing the context and making it simple in terms of invoking the tracers and getting rid of the un-necessary helper functions. Please take a look when time permits.

harshanarayana commented 1 year ago

I am still having issue with make gen command like I used to have before.

damemi commented 1 year ago

@harshanarayana thanks for keeping this alive! are you still having trouble with make gen? I ran it on your branch and it seemed to work. if not, please let me know when this is ready for review

harshanarayana commented 1 year ago

@damemi I've managed to get make gen working inside a container for now.. I've pushed the changes to this branch already.. Please go ahead with review

harshanarayana commented 1 year ago

@damemi I am working on getting the tests fixed as we speak.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [damemi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshanarayana commented 1 year ago

@damemi @a7i PTAL. I have pushed the updated changes based on Mike's suggestion

harshanarayana commented 1 year ago

@a7i Commit pushed with requested changes. PTAL when you can

a7i commented 1 year ago

/lgtm