search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.36k stars 662 forks source link

bump to k8s 1.28 beta.0 #1201

Closed a7i closed 1 year ago

a7i commented 1 year ago

closes #1191 1191

went straight to beta instead of rc

a7i commented 1 year ago

/cc @knelasevero and @ingvagabund

k8s-ci-robot commented 1 year ago

@a7i: GitHub didn't allow me to request PR reviews from the following users: and.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/descheduler/pull/1201#issuecomment-1646382282): >/cc @knelasevero and @ingvagabund Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ingvagabund commented 1 year ago

The master branch is our dev branch. \O/ /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
a7i commented 1 year ago

@ingvagabund how would you want this to happen going forward?

ingvagabund commented 1 year ago

@a7i I meant "let's go". Just an empty phrase so I don't just type "approve" just like that :) All goes as it should go.