kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.36k stars 662 forks source link

.gitattribute to not pollute PRs or stats #1202

Closed a7i closed 1 year ago

a7i commented 1 year ago

Per: https://github.com/github-linguist/linguist/blob/master/docs/overrides.md

Also see: https://github.com/kubernetes/kubernetes/blob/master/.gitattributes

Summary

Git attribute Defined in Effect on file
linguist-detectable [languages.yml] Included in stats, even if language's type is data or prose
linguist-documentation [documentation.yml] Excluded from stats
linguist-generated [generated.rb] Excluded from stats, hidden in diffs
linguist-language=name [languages.yml] Highlighted and classified as name
linguist-vendored [vendor.yml] Excluded from stats
a7i commented 1 year ago

/cc @knelasevero @ingvagabund @damemi

is this something we should support?

a7i commented 1 year ago

/retest-required

ingvagabund commented 1 year ago

From https://github.com/github-linguist/linguist:

This library is used on GitHub.com to detect blob languages, ignore binary or vendored files, suppress generated files in diffs, and generate language breakdown graphs.

I assume that's what we see under Languages: Go 96.3% Shell 2.7% Other 1.0%

+1 for classifying the right blobs.

a7i commented 1 year ago

/retest

knelasevero commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [knelasevero] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knelasevero commented 1 year ago

/retest