search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.26k stars 650 forks source link

fix: descheduler_loop_duration_seconds has wrong value #1215

Closed Abirdcfly closed 11 months ago

Abirdcfly commented 11 months ago

see golang/go#60048

I learned this change from https://github.com/golang/tools/blob/9abb02c1b5524bf655a0985bc101496a6b53ff71/internal/gocommand/invoke.go#L265, thanks to author https://github.com/heschi 🙏

a7i commented 11 months ago

Nice catch and thanks for the references/links! 🏆

/ok-to-test /lgtm

Abirdcfly commented 11 months ago

/test pull-descheduler-verify-master

Abirdcfly commented 11 months ago

please assign ingvagabund for approval

/assign @ingvagabund

thanks.

ingvagabund commented 11 months ago

/approve

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment