search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.44k stars 664 forks source link

topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints #1218

Closed a7i closed 1 year ago

a7i commented 1 year ago

Rebased on top of: https://github.com/kubernetes-sigs/descheduler/pull/1205 https://github.com/kubernetes-sigs/descheduler/pull/1208

to include e2e tests

a7i commented 1 year ago

/label tide/merge-method-squash

a7i commented 1 year ago

/retest

nitindagar0 commented 1 year ago

@a7i , Thank you so much for adding e2e test cases. If PR has been reveived can we merge it?

a7i commented 1 year ago

@nitindagar0 I appreciate your dedication here but every PR must go throw a review and get a lgtm and approve commands (from 2 different reviewers). https://kubernetes.io/docs/contribute/review/for-approvers/

We are also so late in the v0.28 that we probably don't want to include this in the release but rather wait to catch the next minor or patch release.

knelasevero commented 1 year ago

/lgtm

knelasevero commented 1 year ago

We can close the other one and /hold this one until next minor/patch release

nitindagar0 commented 1 year ago

Sure @knelasevero , I have closed the other PR. @a7i makes sense. Please do follow the required process and let me know if further changes required. Also any ETA like when the next patch will be release?

a7i commented 1 year ago

Sure @knelasevero , I have closed the other PR. @a7i makes sense. Please do follow the required process and let me know if further changes required. Also any ETA like when the next patch will be release?

We should have the Descheduler 0.28 release wrapped up this week so this PR should be merged prior to the end of this week. Worst case it will be released next quarter for Kubernetes 1.29, best case we need to cut out a release for 0.28.1

a7i commented 1 year ago

/approve /remove-hold

Thank you @MarcPow and @nitindagar0 for your contribution :trophy:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nitindagar0 commented 1 year ago

Thanks a lot @a7i for all the help. Let us know the status of release of this fix. We will update Descheduler accordingly

a7i commented 1 year ago

The image is available if you want to run it now: gcr.io/k8s-staging-descheduler/descheduler@sha256:373450514057e05a2d96533506ce0cf1f0350ca75d4459c84f081b548da39b0b https://console.cloud.google.com/gcr/images/k8s-staging-descheduler/global/descheduler

but completely understand if you want to wait on an official release

nitindagar0 commented 1 year ago

Hi @a7i, Does this image also includes latest changes of master along with the fix?. Right now, we are using the image shared by your team earlier.

a7i commented 1 year ago

@nitindagar0 up to this commit: https://github.com/kubernetes-sigs/descheduler/commit/99246cd254643aa7a8ddbe41e5d51cfa1ecf5f16

nitindagar0 commented 1 year ago

Thanks @a7i for sharing the image. We will update the image once official release is available.