search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.26k stars 650 forks source link

rename duration metrics #1223

Closed a7i closed 3 months ago

a7i commented 11 months ago

metric subsystem is already descheduler ref

so the new metrics:

show up as:

descheduler_descheduler_strategy_duration_seconds_count{profile="fit",strategy="RemoveFailedPods"} 952

ideally it won't show up with prefix descheduler_descheduler_

knelasevero commented 10 months ago

How should we deal with breaking changes in exposing metrics? With regard to APIs we have the stability/support guide from Kubernetes, so we know what guarantees we offer at alpha/beta/stable and all that, but we don't have similar things about exposing metrics.

So I am not sure. Would it be sufficient to have release notes guiding users on what to do?

a7i commented 10 months ago

I see two options:

  1. Create new metrics and mark the existing ones as deprecated. Followed by removal after 3 releases
  2. Rename existing one and add a breaking changes section to release notes

Given that our metrics are considered ALPHA, option 2 sounds sufficient to me.

lowang-bh commented 10 months ago

/assign

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/descheduler/issues/1223#issuecomment-2022902180): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.