search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.26k stars 650 forks source link

fix: structured err logs in eviction #1228

Closed a7i closed 11 months ago

a7i commented 11 months ago

error logs don't follow correct klog ErrorS syntax

func ErrorS(err error, msg string, keysAndValues ...interface{}) {

https://github.com/kubernetes/klog/blob/main/klog.go#L1599

ingvagabund commented 11 months ago

/approve /lgtm

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment