search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.26k stars 650 forks source link

topologyspreadconstraint: support `matchLabelKeys` #1233

Closed a7i closed 8 months ago

a7i commented 10 months ago

Closes #1171

In Kubernetes 1.27, this feature flag was graduated to beta and it respects topology spread constraints during rolling upgrades. Descheduler currently does not honor this and apps could get unnecessary evictions during rolling upgrade

Ref: https://github.com/kubernetes/enhancements/issues/3243

a7i commented 10 months ago

/cc @ingvagabund

knelasevero commented 9 months ago

This /lgtm would it make sense to add a bit about this in our docs?

a7i commented 8 months ago

@knelasevero updated the docs.

Would you please take a look? also @ingvagabund need help moving this forward since this was officially supported in 1.27 but not in Descheduler 0.27 and 0.28

knelasevero commented 8 months ago

/lgtm

/hold

Hold for a bit to see if Jan has any comments, we can merge by eow if no comments or when another person has eyes on it

ingvagabund commented 8 months ago

/approve /hold cancel

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ingvagabund commented 8 months ago

@a7i this looks great. Thank you for all the refactoring.