kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.44k stars 664 forks source link

helm: support of `timeZone` for CronJob #1245

Closed a7i closed 1 year ago

a7i commented 1 year ago

closes #1243

Stable in 1.27 - field is optional https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/#time-zones

Test:

helm template deschduler ./descheduler -f ./descheduler/values.yaml --set timeZone=Etc/UTC

...
# Source: descheduler/templates/cronjob.yaml
apiVersion: batch/v1
kind: CronJob
metadata:
  name: deschduler-descheduler
  namespace: default
  labels:
    app.kubernetes.io/name: descheduler
    helm.sh/chart: descheduler-0.28.0
    app.kubernetes.io/instance: deschduler
    app.kubernetes.io/version: "0.28.0"
    app.kubernetes.io/managed-by: Helm
spec:
  schedule: "*/2 * * * *"
  concurrencyPolicy: "Forbid"
  timeZone: Etc/UTC
  jobTemplate:
    spec:
...
knelasevero commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [knelasevero] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JaneLiuL commented 1 year ago

/lgtm

a7i commented 1 year ago

/retest