search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.26k stars 650 forks source link

fix: version skew compatibility for managed kubernetes providers #1249

Closed a7i closed 8 months ago

a7i commented 10 months ago

closes #1244

a7i commented 10 months ago

/cc @JaneLiuL

JaneLiuL commented 9 months ago

/lgtm

a7i commented 9 months ago

/cc @ingvagabund and @knelasevero

k8s-ci-robot commented 9 months ago

@a7i: GitHub didn't allow me to request PR reviews from the following users: and.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/descheduler/pull/1249#issuecomment-1763422215): >/cc @ingvagabund and @knelasevero Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a7i commented 8 months ago

@seanmalloy would you have the capacity to review?

ingvagabund commented 8 months ago

/approve

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment