search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.24k stars 645 forks source link

helm: ability to specify `dnsConfig` #1260

Closed audip closed 9 months ago

audip commented 9 months ago

Changes:

This allows specifying dnsConfig block like mentioned in the kubernetes documentation

One example of what's in use at @myfitnesspal is 

      dnsConfig:
        options:
        - name: ndots
          value: "2"
        - name: single-request-reopen
        - name: use-vc

screenshot of how the dns configuration is rendered on the cronjob resource image

k8s-ci-robot commented 9 months ago

Hi @audip. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a7i commented 9 months ago

/label tide/merge-method-squash /ok-to-test

/retitle helm: ability to specify dnsConfig

a7i commented 9 months ago

/lgtm /approve

Tested locally with kubeconform to ensure schema is valid.

Thank you for your contribution @audip

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment