search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.24k stars 645 forks source link

Poor defaults in Helm chart #1266

Closed jgillich closed 3 months ago

jgillich commented 8 months ago

Some of the defaults in the Helm charts seem rather poor:

Thoughts?

a7i commented 8 months ago

Hi @jgillich thanks for the feedback! Please find my response below:

A lot of strategies are enabled by default.

This issue goes away once we move to v1alpha2 in this PR: https://github.com/kubernetes-sigs/descheduler/pull/1139/files That's because profiles is an array

500m cpu request

Yes, I agree. In a cluster of 10k pods, it uses around 100m. Would you be open to creating a PR for this?

The default schedule is every other minute (or every 5 minutes for deployment). Is that necessary?

It depends, we run Descheduler every 2 mins to meet our SLOs. I think this is a good default. 30-60 minutes would burn our SLO budgets in a single day and that's not really a good default for my use-case. Would you be open to creating a PR to make it every 5 minutes?

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/descheduler/issues/1266#issuecomment-2028289631): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ryanovas commented 1 month ago

Is this issue closed on purpose? It seems like these defaults are still active and trying to deploy this with defaults into a smaller cluster can't even schedule the pod