search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.43k stars 664 forks source link

Make the logged nodeutilization percentages human-readable #1294

Closed PeterSzegedi closed 10 months ago

PeterSzegedi commented 10 months ago

A cleaner looking log.

Original:

I1121 15:44:10.570746 47691 nodeutilization.go:198] "Node is underutilized" node="k8s-playground-control-plane" usage={"cpu":"950m","memory":"290Mi","pods":"9"} usagePercentage={"cpu":9.5,"memory":3.696861352760446,"pods":8.181818181818182}

vs.

I1121 16:37:29.266709 60211 nodeutilization.go:204] "Node is underutilized" node="kind-control-plane" usage={"cpu":"950m","memory":"290Mi","pods":"9"} usagePercentage={"cpu":9.5,"memory":3.7,"pods":8.18}

linux-foundation-easycla[bot] commented 10 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 10 months ago

Welcome @PeterSzegedi!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 10 months ago

Hi @PeterSzegedi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PeterSzegedi commented 10 months ago

I have raised a ticket for sorting out my CLA. EasyCLA is unhappy because it does not see my new signed status after invalidating my old one. Hopefully it will get sorted out fairly quickly

DerrickLFX commented 10 months ago

/easycla

PeterSzegedi commented 10 months ago

/easycla

jarias-lfx commented 10 months ago

/easycla

PeterSzegedi commented 10 months ago

The CLA is sorted now. @damemi , @ingvagabund could you give this a review please?

ingvagabund commented 10 months ago

/ok-to-test

ingvagabund commented 10 months ago

/label tide/merge-method-squash

ingvagabund commented 10 months ago

/approve /lgtm

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ingvagabund commented 10 months ago

@PeterSzegedi looks much better now :)