Closed dongjiang1989 closed 9 months ago
Welcome @dongjiang1989!
It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @dongjiang1989. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
cc @a7i PTAL
Thank you for the pr @dongjiang1989 In addition to requested changes, would you please squash and sign your commits?
Thanks for your review. Done. PTAL @a7i
/ok-to-test /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a7i
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
@dongjiang1989 just curious, why do you use a Service for Descheduler?
@dongjiang1989 just curious, why do you use a Service for Descheduler?
The Open Policy Agent is installed in the online kubernetes cluster. All services must have Dual Stack setting. It does not use this service itself.
@dongjiang1989 just curious, why do you use a Service for Descheduler?
The Open Policy Agent is installed in the online kubernetes cluster. All services must have Dual Stack setting. It does not use this service itself.
Then you should be able to omit creating the Service
, correct?
@dongjiang1989 just curious, why do you use a Service for Descheduler?
The Open Policy Agent is installed in the online kubernetes cluster. All services must have Dual Stack setting. It does not use this service itself.
Then you should be able to omit creating the
Service
, correct?
Hmmm... maybe not. OPA must support Deployment and Service appearing in pairs. 🤔️
/lgtm
This pull request adds allow configuration of ipFamilyPolicy for the descheduler service.
Since different versions of k8s have different support for ipv6/ipv4 dual stack, it is not enabled by default.