search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.42k stars 662 forks source link

`PodLifeTime`: consider pods with container status `ImagePullBackOff` #1318

Closed a7i closed 9 months ago

a7i commented 9 months ago

PodLifeTime plugin to support pods with container status ImagePullBackOff

  containerStatuses:
  - image: test-podlifetime:latest
    imageID: ""
    lastState: {}
    name: test-podlifetime
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: Back-off pulling image "test-podlifetime:latest"
        reason: ImagePullBackOff
jklaw90 commented 9 months ago

/lgtm

jklaw90 commented 9 months ago

should we mention this in the readme example? https://github.com/kubernetes-sigs/descheduler?tab=readme-ov-file#podlifetime

a7i commented 9 months ago

good call @jklaw90 - updated ✔️

a7i commented 9 months ago

/retest

seanmalloy commented 9 months ago

/approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [seanmalloy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jklaw90 commented 9 months ago

/lgtm