search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.42k stars 662 forks source link

`PodLifeTime`: update support pods with container status and pods reason #1330

Closed dongjiang1989 closed 9 months ago

dongjiang1989 commented 9 months ago

support pod status reason:

support pod with container status:

k8s-ci-robot commented 9 months ago

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dongjiang1989 commented 9 months ago

/ok-to-test

k8s-ci-robot commented 9 months ago

@dongjiang1989: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/descheduler/pull/1330#issuecomment-1867220475): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dongjiang1989 commented 9 months ago

@a7i PTAL

jklaw90 commented 9 months ago

/ok-to-test

jklaw90 commented 9 months ago

/lgtm

a7i commented 9 months ago

/label tide/merge-method-squash

dongjiang1989 commented 9 months ago

/label tide/merge-method-squash

squash done. @a7i PTAL, thanks

dongjiang1989 commented 9 months ago

/retest-required

dongjiang1989 commented 9 months ago

/retest-required

a7i commented 9 months ago

/approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
a7i commented 9 months ago

/lgtm