kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

chores(verify-gen): fix verify-gen check #1336

Closed dongjiang1989 closed 6 months ago

dongjiang1989 commented 6 months ago

fix make verify-gen case

./hack/verify-conversions.sh
Generated output differs:
diff -Naupr pkg/api/v1alpha2/zz_generated.conversion.go ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/api/v1alpha2/zz_generated.conversion.go
--- pkg/api/v1alpha2/zz_generated.conversion.go 2024-01-02 07:52:35.288783826 +0000
+++ ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/api/v1alpha2/zz_generated.conversion.go   2024-01-02 07:57:50.837405635 +0000
@@ -2,7 +2,7 @@
 // +build !ignore_autogenerated

 /*
-Copyright 2023 The Kubernetes Authors.
+Copyright 2024 The Kubernetes Authors.

 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
diff -Naupr pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go
--- pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go    2024-01-02 07:52:35.288783826 +0000
+++ ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go  2024-01-02 07:57:51.077374503 +0000
@@ -2,7 +2,7 @@
 // +build !ignore_autogenerated

 /*
-Copyright 2023 The Kubernetes Authors.
+Copyright 2024 The Kubernetes Authors.

 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
Generated conversions verify failed. Please run ./hack/update-generated-conversions.sh
make: *** [Makefile:140: verify-gen] Error 1
k8s-ci-robot commented 6 months ago

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a7i commented 6 months ago

/ok-to-test /lgtm

thank you!

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [damemi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment