search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

trim managedFields in shared informer factory #1346

Closed a7i closed 4 months ago

a7i commented 5 months ago

Similar to https://github.com/kubernetes/autoscaler/pull/6159

We recently upgraded to autoscaler 1.29 and noticed a huge memory utilization drop and after further investigation, it appears to be related to omitting managedFields.

For the cluster below, we use server-side-apply (SSA) which stores a big chunk in managedFields. Screenshot 2024-02-01 at 10 02 50 AM

jklaw90 commented 5 months ago

/lgtm

knelasevero commented 4 months ago

nice catch!

knelasevero commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [knelasevero] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment