kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` #1348

Closed a7i closed 4 months ago

a7i commented 4 months ago

RemovePodsHavingTooManyRestarts plugin has a includeInitContainers field but it doesn't actually check for init container status

jklaw90 commented 4 months ago

/lgtm

knelasevero commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [knelasevero] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment