Closed tioxy closed 4 months ago
Hi @tioxy. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@a7i Tried following the suggestion of using EvictOptions
. Also added support for StrategyName
and deprecated context references for it.
Thank you for the patience and attention! 😀 👍
really good changes and clean-up 🏆
/label tide/merge-method-squash /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a7i
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Thank you for your contribution and patience! 🏆
Just realized another change was missing here.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Supports profile name set under the label
profile
for the metricpods_evicted
.This allows the possibility of alerting different severities for different profiles.
Also, some refactors related to
EvictOptions
to make it more standard.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
I really do not thinkProfileName
as a public function was the best idea forPodEvictor
, but adding toNewPodEvictor
would require changes over many lines of code. Any suggestions on how to improve it?Already discussed in the comments.
Results for
v1alpha1
Config
Metric output
Results for
v1alpha2
Config
Metric output
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: