search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

Closed nikimanoledaki closed 3 months ago

nikimanoledaki commented 4 months ago

Closes https://github.com/kubernetes-sigs/descheduler/issues/1279 More context: https://github.com/kubernetes-sigs/descheduler/issues/1149

This PR:

k8s-ci-robot commented 4 months ago

Hi @nikimanoledaki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikimanoledaki commented 4 months ago

/ok-to-test

@damemi thank you for approving the tests - I fixed the linter issue, would it be possible to run them again please?

ingvagabund commented 3 months ago

/retest pull-descheduler-verify-master

k8s-ci-robot commented 3 months ago

@ingvagabund: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/descheduler/pull/1356#issuecomment-1978161685): >/retest pull-descheduler-verify-master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knelasevero commented 3 months ago

I think this can get in before we redesign nodeFit, as @a7i pointed out.

gonna approve and let lgtm's for other maintainers and @logyball

/approve

nikimanoledaki commented 3 months ago

/test all

nikimanoledaki commented 3 months ago

Hi @a7i 👋 I would really appreciate your review since we discussed this feature on Slack. Thank you!

logyball commented 3 months ago

/approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero, logyball

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [knelasevero] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nikimanoledaki commented 3 months ago

@a7i thanks for taking a look. Is the PR ok to merge? Would appreciate your help with this / next steps, thank you!

ingvagabund commented 3 months ago

The changes look reasonable in general. Thank you for your time and energy. Would you please reduce the number of commits in the PR to make the code changes easier to follow? E.g. making functions/methods private right away, moving code forth and back in a single commit, building the new functions right way in a single commit, etc.

nikimanoledaki commented 3 months ago

Thank you @ingvagabund! I rewrote the history a bit to remove in-between draft steps & duplications, as well as group unit test commits :) Could you review when you can please? Thank you!

/test all

nikimanoledaki commented 3 months ago

/cc ingvagabund

a7i commented 3 months ago

@nikimanoledaki I'm working on getting this merged today. We have a CI job that is stuck

a7i commented 3 months ago

/lgtm

a7i commented 3 months ago

seems to be stuck on linting: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_descheduler/1356/pull-descheduler-verify-master/1767621656668278784

a7i commented 3 months ago

/retest-required

a7i commented 3 months ago

thank you for your contribution @nikimanoledaki 🏆

nikimanoledaki commented 3 months ago

Thank you so much for the reviews and help @a7i @logyball @ingvagabund @knelasevero @damemi! 🎉 🥳