Closed tioxy closed 4 months ago
Hi @tioxy. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/retest-required
/lgtm /approve
thanks for the quick fix!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a7i
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR introduced extended observability capabilities. One of the strategies (
RemovePodsViolatingNodeTaints
) is pointing to the wrong field (ProfileName
instead ofStrategyName
). Looks like the only placeprofileName
should be set is here.This change fixes it by pointing right struct field.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: