search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

Helm chart does not allow "falsey" value in `cmdOptions` #1371

Closed fullykubed closed 1 month ago

fullykubed commented 3 months ago

What version of descheduler are you using?

descheduler version: v0.29.0

Does this issue reproduce with the latest release?

Yes

What did you do?

Tried to deploy the helm chart with cmdOptions.v equal to 0.

What did you expect to see?

The descheduler started with --v=0.

What did you see instead?

The descheduler started with --v.

Root Cause

This line is incorrect as it is not possible to provide a "falsey" value such as 0.

omerap12 commented 2 months ago

/assign