use cmd context instead of using context.Background()

kubernetes-sigs / descheduler

Descheduler for Kubernetes

https://sigs.k8s.io/descheduler

Apache License 2.0

4.23k stars 645 forks source link

use cmd context instead of using context.Background() #1416

Closed googs1025 closed 1 month ago

googs1025 commented 1 month ago

use cmd context instead of using context.Background(). cmd *cobra.Command provided the context ctx, we should use this one provided by cmd instead of using context.Background(). We should pass the upstream ctx to the downstream.

a7i commented 1 month ago

cc: @jklaw90

jklaw90 commented 1 month ago

/lgtm

a7i commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment