Open der-eismann opened 1 month ago
I may have tagged the release incorrectly. cc: @damemi
I don't see a git tag for v20240519-v0.30.0
in github, @a7i can you remember the order of the steps you did? In relation to https://github.com/kubernetes-sigs/descheduler/blob/master/docs/release-guide.md#release-process
That said we might be able to fix it by just tagging a new version. I don't know if we can delete the old k8s registry images but we might be able to
Yes, I followed those steps.
Looks like Descheduler version parsing broke in this commit https://github.com/kubernetes-sigs/descheduler/commit/dca2e58b8e705ad60b3c060f541e9d0a43238fe0
I can submit a fix soon
@a7i no worries, I wasn't implying that you didn't follow those steps. I just meant that we could trace back through that flowchart to try to figure out what could have happened :) looks like you've tracked it down though
Mega, thanks for the quick fix!
What version of descheduler are you using?
descheduler version: 0.30.0
Does this issue reproduce with the latest release?
yes
Which descheduler CLI options are you using?
--kubeconfig container/config-staging --policy-config-file container/policy.yaml
Please provide a copy of your descheduler policy config file
What k8s version are you using (
kubectl version
)?kubectl version
OutputWhat did you do?
Start the descheduler
What did you expect to see?
No warning
What did you see instead?
This on every start:
I don't know why the
GitVersion
is used to parse here - it has a format ofv20240519-v0.30.0
. According to the docs ofutilversion.ParseGeneric
:The version it's trying to parse however is this (obtained from
descheduler version
- also see the doublev
):My suggestion would be to either replace
VERSION?=v$(shell date +%Y%m%d)-$(shell git describe --tags)
in the Makefile withVERSION?=$(shell git describe --tags)-$(shell date +%Y%m%d)
(but no idea what other implications that would have) or alternatively just parseversionInfo.Minor
in the descheduler.go. But the way it is right now is just broken.