refactor some methods in e2e test

kubernetes-sigs / descheduler

Descheduler for Kubernetes

https://sigs.k8s.io/descheduler

Apache License 2.0

4.23k stars 645 forks source link

refactor some methods in e2e test #1441

Closed googs1025 closed 1 week ago

googs1025 commented 1 week ago

/kind cleanup

Use outer ctx instead of context.TODO()
use wait.PollUntilContextTimeout instead of wait.PollImmediate

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ingvagabund commented 1 week ago

/lgtm