search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

fix: helm leader-election typo to `resourceNamespace` #1443

Open a7i opened 1 week ago

a7i commented 1 week ago

reported issue: https://kubernetes.slack.com/archives/C09TP78DV/p1718633429179519

Test using leaderElection.resourceNamescape

helm template deschduler ./descheduler -f ./descheduler/values.yaml --set kind=Deployment --set=leaderElection.enabled=true --set=leaderElection.resourceNamescape=foo

Error: execution error at (descheduler/templates/deployment.yaml:62:16): 'leaderElection.resourceNamescape' is deprecated. instead use 'leaderElection.resourceNamespace'

Test using leaderElection.resourceNamespace


helm template deschduler ./descheduler -f ./descheduler/values.yaml --set kind=Deployment --set=leaderElection.enabled=true --set=leaderElection.resourceNamespace=foo | grep leader-elect-resource-namespace

            - --leader-elect-resource-namespace=foo
k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from a7i. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment