kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

Unit-test: add necessary ownerRef to the pod. #1445

Closed zhifei92 closed 6 days ago

zhifei92 commented 1 week ago

There are cases where Pods have not had ownerReferences added, leading to certain test scenarios not yielding the expected outcomes. For instance, in the scenario "case: without priorities, but excluding namespaces," the reason pod1- pod5 were not evicted was due to "the Pod does not have any ownerReferences," as opposed to a namespace mismatch, because these Pods were not configured with ownerReferences.

I0621 19:51:50.729704   15876 defaultevictor.go:238] "Pod fails the following checks" pod="kube-system/p8" checks="[pod does not have any ownerRefs, pod has system critical priority]"
I0621 19:51:50.729715   15876 defaultevictor.go:238] "Pod fails the following checks" pod="namespace1/p1" checks="pod does not have any ownerRefs"
I0621 19:51:50.729722   15876 defaultevictor.go:238] "Pod fails the following checks" pod="namespace1/p2" checks="pod does not have any ownerRefs"
I0621 19:51:50.729729   15876 defaultevictor.go:238] "Pod fails the following checks" pod="namespace1/p3" checks="pod does not have any ownerRefs"
I0621 19:51:50.729736   15876 defaultevictor.go:238] "Pod fails the following checks" pod="namespace1/p4" checks="pod does not have any ownerRefs"
I0621 19:51:50.729757   15876 defaultevictor.go:238] "Pod fails the following checks" pod="namespace1/p5" checks="pod does not have any ownerRefs"

And I haven't fixed "case: without priorities, but include only default namespace", because LowNodeUtilization does not support inclusion. I will proceed with this work when inclusion is supported.

https://github.com/kubernetes-sigs/descheduler/blob/cdbd101eaecb97c56b5a520078528e86d736e9ea/pkg/framework/plugins/nodeutilization/lownodeutilization_test.go#L227-L251

BTW, why LowNodeUtilization does not support namespace inclusion

k8s-ci-robot commented 1 week ago

Welcome @zhifei92!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 week ago

Hi @zhifei92. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jklaw90 commented 1 week ago

/ok-to-test

ingvagabund commented 6 days ago

Good catch. Thank you.

/approve /lgtm

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment