Closed zhifei92 closed 6 days ago
Welcome @zhifei92!
It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @zhifei92. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Good catch. Thank you.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ingvagabund
The full list of commands accepted by this bot can be found here.
The pull request process is described here
There are cases where Pods have not had ownerReferences added, leading to certain test scenarios not yielding the expected outcomes. For instance, in the scenario "case: without priorities, but excluding namespaces," the reason pod1- pod5 were not evicted was due to "the Pod does not have any ownerReferences," as opposed to a namespace mismatch, because these Pods were not configured with ownerReferences.
And I haven't fixed "case: without priorities, but include only default namespace", because LowNodeUtilization does not support
inclusion
. I will proceed with this work wheninclusion
is supported.https://github.com/kubernetes-sigs/descheduler/blob/cdbd101eaecb97c56b5a520078528e86d736e9ea/pkg/framework/plugins/nodeutilization/lownodeutilization_test.go#L227-L251
BTW, why
LowNodeUtilization
does not supportnamespace inclusion
?