search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

Update options.go #1448

Closed jaychenthinkfast closed 6 days ago

jaychenthinkfast commented 6 days ago

\n can't work in this usage , remove

k8s-ci-robot commented 6 days ago

Hi @jaychenthinkfast. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
googs1025 commented 6 days ago

/ok-to-test

googs1025 commented 6 days ago

/kind cleanup

ingvagabund commented 6 days ago

/approve /lgtm

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/release-1.27/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ingvagabund commented 6 days ago

This helps :) Thank you

ingvagabund commented 6 days ago

/hold

I don't see the test running. Just EasyCLA check. Let's wait until other checks appear as well.

ingvagabund commented 6 days ago

Oh, this is 1.27 release :) @jaychenthinkfast we no longer release for this branch.