search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.23k stars 645 forks source link

fix: indexer cache error when default evictor is re-initialized #1452

Open a7i opened 3 days ago

a7i commented 3 days ago

It appears that DefaultEvictor is re-initialized, which causes a conflict issue when adding the same indexer again.

closes #1440

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from a7i. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
a7i commented 3 days ago

/cc @ingvagabund

any ideas on how to make this better? to be honest, I'm not sure why DefaultEvictor is getting re-initialized. But perhaps this is possible in case of multiple profiles