search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.42k stars 662 forks source link

test: generate uid when building a pod #1454

Closed ingvagabund closed 3 months ago

ingvagabund commented 3 months ago

UID is an integral part of every pod. Even though we don't test for UID in any of the existing test cases, future test cases might rely on it.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/descheduler/blob/master/OWNERS)~~ [a7i] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
a7i commented 3 months ago

/lgtm

ingvagabund commented 3 months ago

/retest-required

ingvagabund commented 3 months ago

/test pull-descheduler-verify-master