search

kubernetes-sigs / descheduler

Descheduler for Kubernetes
https://sigs.k8s.io/descheduler
Apache License 2.0
4.48k stars 669 forks source link

Migrate all e2es to run descheduler as an image #1478

Open ingvagabund opened 3 months ago

ingvagabund commented 3 months ago

With https://github.com/kubernetes-sigs/descheduler/pull/1474 we can run the descheduler through a pod. End-to-end testing is not intended to run the descheduler code directly, as this does not accurately reflect its operation in production. Each e2e test can be refactored separately. https://github.com/kubernetes-sigs/descheduler/pull/1472 is an example of the first step running the descheduler as a whole. While https://github.com/kubernetes-sigs/descheduler/pull/1474 gives idea on how to run it as a deployment.

The following e2es need to be migrated:

ingvagabund commented 3 months ago

@jklaw90 @JaneLiuL @fanhaouu @pravarag @eminaktas @zhifei92 @googs1025 in case you would like to contribute

fanhaouu commented 2 months ago

@jklaw90 @JaneLiuL @fanhaouu @pravarag @eminaktas @zhifei92 @googs1025 in case you would like to contribute

Not sure if there is an ETA, I can make some contributions. @ingvagabund

ingvagabund commented 2 months ago

There's no ETA. Also, there's no guarantee the issue will stay unresolved for long. I will eventually migrate all the e2es to simplify https://github.com/kubernetes-sigs/descheduler/pull/1466.

fanhaouu commented 2 months ago

There's no ETA. Also, there's no guarantee the issue will stay unresolved for long. I will eventually migrate all the e2es to simplify #1466.

ok

hsunwenfang commented 2 months ago

Hi @ingvagabund I would like to contribute, thx!

ingvagabund commented 2 months ago

@hsunwenfang thank you. Any of the listed items is currently for taking.

fanhaouu commented 2 months ago

I have completed some E2E tests, but encountered some issues when running the E2E tests locally. I am still debugging and working on resolving them. @ingvagabund @ingvagabund

hsunwenfang commented 2 months ago

Hi @ingvagabund I'm working on TestLeaderElection and is refering your commit https://github.com/kubernetes-sigs/descheduler/pull/1472/commits/ab467a5dd29925eb3fd794d2d93965f4a58281fc Where in L57 the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported While there is no corresponding folder for leaderelection Should "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" be used instead? Or should there be another way to do it Thanks!!

googs1025 commented 2 months ago

Hi @ingvagabund I'm working on TestLeaderElection and is refering your commit ab467a5 Where in L57 the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported While there is no corresponding folder for leaderelection Should "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" be used instead? Or should there be another way to do it Thanks!!

Can you provide more information? If you are working on this issue, you can also raise a WIP PR to ask the question.

hsunwenfang commented 2 months ago

Hi @googs1025 Thanks for the instruction WIP PR raised and added detail to my ask there https://github.com/kubernetes-sigs/descheduler/pull/1497#issuecomment-2290503550

ingvagabund commented 2 months ago

@hsunwenfang dropped comments in the wip pr :)

@fanhaouu do the issues reproduce only locally?

fanhaouu commented 2 months ago

@hsunwenfang dropped comments in the wip pr :)

@fanhaouu do the issues reproduce only locally?

In theory, it should also exist online. There's an issue with some of the code you wrote. I'll make some adjustments, and you can review it later.For example, the current container E2E test didn't meet expectations, but it still shows as 'pass'.

fanhaouu commented 2 months ago

done: https://github.com/kubernetes-sigs/descheduler/pull/1500