kubernetes-sigs / dra-example-driver

Example DRA driver that developers can fork and modify to get them started writing their own.
Apache License 2.0
51 stars 32 forks source link

update deployment for 1.31 #48

Closed pohly closed 2 days ago

pohly commented 5 months ago

https://github.com/kubernetes/kubernetes/pull/125163 is making the drivers responsible for publishing ResourceSlices and getting the ResourceClaim. The example driver needs to be updated to work with that change.

Furthermore, we need to demonstrate how apiserver access can be limited. See https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/deploy/example/plugin-permissions.yaml.

We also should document that deployments are expected to limit access to admin access as in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/deploy/example/admin-access-policy.yaml

pohly commented 5 months ago

Some relevant documentation:

pohly commented 5 months ago

/assign @carlory

carlory commented 4 months ago

/unassign

For some reason, I may not have time to complete this task. If I am free and the task still needs volunteers, I will come back to claim it. sorry for the delay @pohly

carlory commented 4 months ago

If someone raises a PR, I am very happy to review together

jackfrancis commented 2 months ago

should we close this based on https://github.com/kubernetes-sigs/dra-example-driver/pull/50 ?

klueska commented 2 months ago

Yes. Closed by https://github.com/kubernetes-sigs/dra-example-driver/pull/53

klueska commented 2 months ago

Actually, let's reopen this, as not all all of the criteria that @pohly mentions in the issue has been fulfilled. That is to say that basic support for 1.31 has been merged (i.e. it is functional), but it doesn't check all of the boxes that @pohly has for being done the "right" way.

pohly commented 2 months ago

I agree, let's add at least the RBAC rules. I've updated the description with more recent links.

pohly commented 3 weeks ago

/assign

pohly commented 3 weeks ago

/unassign /assign @bart0sh

pohly commented 3 weeks ago

/wg device-management /milestone v1.32

jackfrancis commented 3 weeks ago

cc @nojnhuh @ritazh