kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.
Apache License 2.0
529 stars 103 forks source link

Validate kindConfigFile while configuring Kind cluster #319

Closed dmvolod closed 1 year ago

dmvolod commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fix the situation, when someone would like to create Kind cluster with options, but without kindConfigFile defined, i.e.

envfuncs.CreateClusterWithConfig(kind.NewProvider(), kindClusterName, "", kind.WithImage("kindest/node:v1.22.2")),

In this case, create procedure will fails with unpredictable behavior:

15:14 $ make e2e 
go test ./test/e2e/... --v 4
F0906 15:17:25.100154   88839 env.go:375] Setup failure: failed to create kind cluster: exit status 1 : exit status 1: ERROR: unknown command "kindest/node:v1.27.3" for "kind create cluster"

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., Usage docs, etc.:

k8s-ci-robot commented 1 year ago

Welcome @dmvolod!

It looks like this is your first PR to kubernetes-sigs/e2e-framework 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/e2e-framework has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vladimirvivien commented 1 year ago

/ok-to-test

harshanarayana commented 1 year ago

/retest-required

harshanarayana commented 1 year ago

@dmvolod thanks very much for this contribution. Would you mind adding this same check under https://github.com/kubernetes-sigs/e2e-framework/blob/main/support/kwok/kwok.go as well?

harshanarayana commented 1 year ago

@dmvolod Are you still working on this ?

dmvolod commented 1 year ago

@harshanarayana yes, sure, sorry for delay, will fix in few couple of days.

harshanarayana commented 1 year ago

No worries @dmvolod I was just checking to see if you were still looking into this or not. No hurry! Take your time.

dmvolod commented 1 year ago

@harshanarayana added configFile validation logic for kwok

harshanarayana commented 1 year ago

/lgrm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmvolod, harshanarayana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/e2e-framework/blob/main/OWNERS)~~ [harshanarayana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshanarayana commented 1 year ago

/lgtm