search

kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.
Apache License 2.0
522 stars 101 forks source link

CLI flags for "running only given features" will skip whole test if a feature in the env doesn't match the criteria. #426

Closed 0sewa0 closed 5 days ago

0sewa0 commented 5 months ago

What happened?

When using the --labels "key=value" argument, the Feature with that label didn't run. All Features got skipped, regardless of the label they have, because the first in the Environment didn't have the label.

What did you expect to happen?

Run all the Features that have the label, and skip the ones that don't.

How can we reproduce it (as minimally and precisely as possible)?

Have 2 Features, only second one has the label, try to run only the second one using the --labels arg.

Anything elese we need to know?

Tried it with the --feature arg as well, same problem.

E2E Provider Used

real cluster

e2e-framework Version

v0.4.0

OS version

```console OS: MacOS 14.5 (Intel Machine) ```
0sewa0 commented 5 months ago

I am not familiar with the code(at all), and how it's structured, but out of curiosity, I went digging:

I think https://github.com/kubernetes-sigs/e2e-framework/blame/72aa5e3c117ef7c0a430328fa4b6e61edbdcf790/pkg/env/env.go#L209-L212 is incorrect.

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 days ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 days ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/e2e-framework/issues/426#issuecomment-2454851898): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.