Closed 0sewa0 closed 2 weeks ago
I am not familiar with the code(at all), and how it's structured, but out of curiosity, I went digging:
I think https://github.com/kubernetes-sigs/e2e-framework/blame/72aa5e3c117ef7c0a430328fa4b6e61edbdcf790/pkg/env/env.go#L209-L212 is incorrect.
t.Skipf
just skip the whole test, not only the Feature
? 🤔 return ctx
be a fix ? (with some log before it, of course 😅 )The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
What happened?
When using the
--labels "key=value"
argument, theFeature
with that label didn't run. AllFeatures
got skipped, regardless of the label they have, because the first in theEnvironment
didn't have the label.What did you expect to happen?
Run all the
Features
that have the label, and skip the ones that don't.How can we reproduce it (as minimally and precisely as possible)?
Have 2
Features
, only second one has the label, try to run only the second one using the--labels
arg.Anything elese we need to know?
Tried it with the
--feature
arg as well, same problem.E2E Provider Used
real cluster
e2e-framework
Versionv0.4.0
OS version